Skip to content

chore: migrate wrapper to call Master Workflow.yml directly - #70

Merged
MichielOda merged 2 commits into
mainfrom
chore/wrapper-migration-nuget
Sep 30, 2026
Merged

MichielOda merged 2 commits into
mainfrom
chore/wrapper-migration-nuget

Conversation

@SkylineCICD

Copy link
Copy Markdown
Contributor

This PR was opened automatically by the
Wrapper Migration Workflow in
SkylineCommunications/_ReusableWorkflows.

What changed

The wrapper workflow file(s) in .github/workflows/ were
updated to call
SkylineCommunications/_ReusableWorkflows/.github/workflows/Master Workflow.yml
directly instead of the legacy
nuget master wrapper. Input and
secret names were renamed to the kebab-case / SHOUTING_CASE
names that Master Workflow.yml expects, and any obsolete
passthrough inputs (referenceName, runNumber,
referenceType, repository, owner, …) were dropped.

Why

The legacy NuGet Solution, Internal NuGet Solution and
DataMiner App Packages master workflows are thin wrappers
that internally call Master Workflow.yml. Removing the
indirection:

  • shortens the CI call chain by one job;
  • exposes the full set of Master Workflow.yml inputs
    (e.g. runs-on) without us having to forward each one
    through every wrapper;
  • lets us evolve the master inputs without breaking
    callers.

Review checklist

  • The rewrite preserves all with: values that were
    previously passed through (only the keys were
    renamed).
  • All secrets: mappings are intact.
  • If your wrapper job had extra steps or conditions
    around the legacy uses: call, verify they still
    make sense pointing at the master workflow.
  • CI on this PR is green.

Idempotent: re-running the legacy wrapper while this PR
is open will not create another one.

janstaelensskyline and others added 2 commits September 29, 2026 14:23
The 'nuget' legacy master workflow is a
thin wrapper around Master Workflow.yml. Removing it shortens
the call chain by one job, exposes the full set of
Master Workflow inputs (e.g. runs-on), and lets us evolve
inputs without breaking callers.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants