add kafka reporter #596
Merged
add kafka reporter #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix CI. |
lu-xiaoshuang
force-pushed
the
kafka-reporter
branch
from
c73095f
to
cab1234
Compare
|
Hi @liuhaoyang & @wu-sheng, shall we merge this pull request to main branch? |
|
@liuhaoyang needs to review this first. I would not merge any function relative PR. |
liuhaoyang
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting pull request
Why submit this pull request?
New feature provided
How to test?
grpc server:
set ASPNETCORE_ENVIRONMENT=Development && set ASPNETCORE_HOSTINGSTARTUPASSEMBLIES=SkyAPM.Agent.AspNetCore && sample\grpc\SkyApm.Sample.GrpcServer\bin\Release\net6.0\SkyApm.Sample.GrpcServer.exegrpc client:
set ASPNETCORE_ENVIRONMENT=Development && set ASPNETCORE_HOSTINGSTARTUPASSEMBLIES=SkyAPM.Agent.AspNetCore && sample\grpc\SkyApm.Sample.GrpcClient\bin\Release\net6.0\SkyApm.Sample.GrpcClient.exeSEE ALSO #559