Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update to webonyx/graphql-php ^15 #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Update to webonyx/graphql-php ^15 #39

wants to merge 2 commits into from

Conversation

L3tum
Copy link

@L3tum L3tum commented Feb 10, 2024 •
edited
Loading

Proposed changes

  • I've updated the lib to version 15
  • To note is that I also removed some of the filtering that was going on in FederatedSchemaPrinter. I had that in a local branch for a while because otherwise the whole thing wouldn't work with Apollo and that has been confirmed by a rep as well, so I included those changes in this PR.

How to test

  • The usual I guess^^

Unit Tests

  • This PR has unit tests
  • This PR does not have unit tests: why?

FYI I've seen the two other PRs open so idk if you want to include this change. I had to fork the repo anyways and thought I'd contribute back, but it's alright if you don't wanna merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@L3tum