Create some unit tests #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joserc87
commented
Feb 13, 2021
| @@ -170,7 +211,7 @@ def getFarmInfo(saveFile): | |||
| g = int(crop.find("tintColor").find("G").text) | |||
| b = int(crop.find("tintColor").find("B").text) | |||
| days = int(crop.find("dayOfCurrentPhase").text) | |||
| o = ((r, g, b), days) | |||
There was a problem hiding this comment.
Note: This change seems gratuitous, but it's needed for the test to check agains tthe expected output, which is a list because it comes from a JSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I'm crating some unit tests for emailDrone and for farmInfo (reading of some sample data). They should be harmless to run, as they don't connect to any external resource. Nevertheless these commits change the code slightly so we should make sure that the project is still running just fine before merging.
In some later PR I'll create integration tests that checks the API, which is more interesting at the current state of the project.