Use LibWally descriptors #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sjors
force-pushed
the
2022/01/descriptors
branch
from
e90a6f0 to
2ae2267
Compare
Currently we generate the addresses by taking the cosigner public keys, turning them into a multisig scriptPubKey and then converting that to an address. This commit uses the wallet descriptor directly, now that LibWally support this.
Sjors
force-pushed
the
2022/01/descriptors
branch
from
2ae2267 to
4e25ed6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on Sjors/libwally-swift#57
This switches the address list view to use the new libwally-core functionality for deriving an address from a descriptor.
We still need https://github.com/Sjors/output-descriptors-swift to process the wallet descriptor, in order to find out the cosigner keys and threshold value. But it should be straight-forward to expose that (currently internal) functionality in libwally-core.