Closed
Conversation
…of building from source - Download pre-built binaries from bitcoincore.org instead of cloning and building Bitcoin Core from source (~7 min savings) - Mine first 17 blocks via RPC generatetoaddress to avoid the IPC extranonce issue at low heights (no patch needed for pre-built binaries) - Update find_bitcoin() to support both downloaded and built-from-source binary layouts - Remove stale coinbase cache (regenerated on first test run) - Update DEVELOP.md with download instructions Co-authored-by: Sjors <10217+Sjors@users.noreply.github.com> Agent-Logs-Url: https://github.com/Sjors/btc-accounting/sessions/99daa589-26a0-48a0-ba58-214f360fd00f
…rification Co-authored-by: Sjors <10217+Sjors@users.noreply.github.com> Agent-Logs-Url: https://github.com/Sjors/btc-accounting/sessions/99daa589-26a0-48a0-ba58-214f360fd00f
Copilot
AI
changed the title
[WIP] Pin Bitcoin Core version in CI
Pin Bitcoin Core v31.0rc1: download pre-built binaries in CI
Mar 22, 2026
Sjors
requested changes
Mar 22, 2026
| - name: Download Bitcoin Core | ||
| run: | | ||
| cd bitcoin-core | ||
| git apply ../bitcoin-core-ipc-extranonce.patch |
Owner
There was a problem hiding this comment.
Oh right, we can't use the binaries, we have to clone the repo and apply this patch.
Author
There was a problem hiding this comment.
Reverted to clone + patch + build. Now the only change is --branch master → --branch v31.0rc1 in b405f0d.
Keep the clone + patch + build approach but pin to v31.0rc1 tag so ccache stays valid across CI runs. Co-authored-by: Sjors <10217+Sjors@users.noreply.github.com> Agent-Logs-Url: https://github.com/Sjors/btc-accounting/sessions/a7d32120-0bac-41b8-b5af-2a97bb644d86
Copilot
AI
changed the title
Pin Bitcoin Core v31.0rc1: download pre-built binaries in CI
Pin Bitcoin Core to v31.0rc1 tag in CI
Mar 22, 2026
Owner
|
@copilot can you squash the commits? |
Author
I rewrote this locally, but the available tooling here won’t force-push rewritten history, so I couldn’t update the remote branch to the squashed commit. The branch content is already the minimal one-line change in |
Sjors
added a commit
that referenced
this pull request
Mar 22, 2026
More likely to get ccache hits. The patch is still applied, see: #5 (comment)
Owner
|
Squashed and merged into 1f30fb1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.