-
-
Notifications
You must be signed in to change notification settings - Fork 888
Allow Build with Visual Studio For Mac #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
=========================================
- Coverage 88.84% 88.75% -0.1%
=========================================
Files 1015 1015
Lines 44167 44167
Branches 3181 3181
=========================================
- Hits 39241 39201 -40
- Misses 4201 4206 +5
- Partials 725 760 +35
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #833 +/- ##
=========================================
- Coverage 88.84% 88.75% -0.1%
=========================================
Files 1015 1015
Lines 44167 44167
Branches 3181 3181
=========================================
- Hits 39241 39201 -40
- Misses 4201 4206 +5
- Partials 725 760 +35
Continue to review full report at Codecov.
|
Prerequisites
Description
Visual Studio for Mac has a pretty sever limitation when building multitargeting projects.
https://bugzilla.xamarin.com/show_bug.cgi?id=55508#c5
This PR reorders the target frameworks so that
netcoreapp2.1is the first target in all relevant projects and adds the target to ImageSharp.Drawing (we'll probably need it for future perf work anyway).