-
-
Notifications
You must be signed in to change notification settings - Fork 844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for metadata conversion between formats. #2751
Open
JimBobSquarePants
wants to merge
32
commits into
main
Choose a base branch
from
js/format-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This is one of those monster PRs that everyone hates but since it touches all image formats was unavoidable.
This PR stems from the v4 roadmap discussion here.
It does three things.
Two bridging metadata types
FormatConnectingMetadata
andFormatFrameConnectingMetadata
have been introduced along with interfacesIFormatMetadata
,IFormatMetadata<TSelf>
,IFormatFrameMetadata
,IFormatFrameMetadata<TSelf>
which enforce conversion APIs between all our format metadata types.Naming conventions, type usage, and behavior has also been normalized across all our metadata types.
PixelColorType
has been expanded to allow for exotic types not used in our own pixel formats and is now present alongsidePixelComponentInfo
andPixelAlphaRepresentation
in thePixelTypeInfo
instance returned withImageInfo
.