Relaxed bmp dimensions validation #2192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brianpopow
reviewed
Aug 24, 2022
dlemstra
reviewed
Sep 8, 2022
| /// <summary> | ||
| /// Maximum dimensions of a bitmap with or height: 2**31 - 1, since width and height are int32 | ||
| /// </summary> | ||
| private const int MaximumBmpDimension = 2147483647; |
Collaborator
There was a problem hiding this comment.
no, it's no longer used, it's now removed.
JimBobSquarePants
approved these changes
Sep 9, 2022
Member
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Thanks for finishing this off.
When I first looked at this, I thought we'd be encoding using one of the older headers using unsigned width/height so thought it would be more complicated.
This was referenced Sep 29, 2025
This was referenced Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Relaxed bmp header dimensions checks so now the maximum possible values are accepted.