Skip to content

Conversation

@miere43
Copy link
Contributor

@miere43 miere43 commented Apr 9, 2022

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Added missing PngChunk.Dispose call to avoid memory leak in PngDecoderCore

All relevant information in issue #2080

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2022

CLA assistant check
All committers have signed the CLA.

@miere43 miere43 changed the title Fix chunk data memory leak when decoding PNG #2080 Fix chunk data memory leak when decoding PNG Apr 9, 2022
@tocsoft
Copy link
Member

tocsoft commented Apr 12, 2022

@miere43 Thanks a lot for this fix.

Turns out most of our test images suffer from this same issue, I have merged your fix (but not your tests) into #2082 so your fix has been merged via that PR instead so I'm going to close this one.

@tocsoft tocsoft closed this Apr 12, 2022
@JimBobSquarePants JimBobSquarePants added this to the 2.1.1 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants