Skip to content

Expose ImageFrame<TPixel>.PixelBuffer #1906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Expose ImageFrame<TPixel>.PixelBuffer #1906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/ImageSharp/ImageFrame{TPixel}.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,8 @@ internal ImageFrame(Configuration configuration, ImageFrame<TPixel> source)
source.PixelBuffer.FastMemoryGroup.CopyTo(this.PixelBuffer.FastMemoryGroup);
}

/// <summary>
/// Gets the image pixels. Not private as Buffer2D requires an array in its constructor.
/// </summary>
internal Buffer2D<TPixel> PixelBuffer { get; private set; }

/// <inheritdoc/>
Buffer2D<TPixel> IPixelSource<TPixel>.PixelBuffer => this.PixelBuffer;
public Buffer2D<TPixel> PixelBuffer { get; private set; }
Copy link
Member

@antonfirsov antonfirsov Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can <inheritdoc/> publicly inherit docs from an internal interface?

Copy link
Member Author

@JimBobSquarePants JimBobSquarePants Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly have no idea. I think it triggers a copy of the docs though during build rather than reference the original

Copy link
Member

@antonfirsov antonfirsov Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we check it during doc generation, and fix if it doesn't work.

Copy link
Member Author

@JimBobSquarePants JimBobSquarePants Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intellisense seems to be working in consuming project.


/// <summary>
/// Gets or sets the pixel at the specified position.
Expand Down