Skip to content

Conversation

@br3aker
Copy link
Contributor

@br3aker br3aker commented Dec 17, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Closes #1894. Moved mentioned image from decoder tests to 'throws exception' tests.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #1899 (791a1a1) into master (a356848) will decrease coverage by 0%.
The diff coverage is 83%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1899   +/-   ##
======================================
- Coverage      87%     87%   -1%     
======================================
  Files         960     960           
  Lines       50975   50979    +4     
  Branches     6311    6312    +1     
======================================
+ Hits        44733   44736    +3     
  Misses       5202    5202           
- Partials     1040    1041    +1     
Flag Coverage Δ
unittests 87% <83%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...p/Formats/Jpeg/Components/Decoder/JpegComponent.cs 93% <ø> (-1%) ⬇️
src/ImageSharp/Formats/Jpeg/JpegDecoderCore.cs 89% <80%> (-1%) ⬇️
src/ImageSharp/Common/Helpers/Numerics.cs 97% <100%> (+<1%) ⬆️
src/ImageSharp/Formats/Jpeg/JpegThrowHelper.cs 60% <100%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a356848...791a1a1. Read the comment docs.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@JimBobSquarePants JimBobSquarePants merged commit 39f37d0 into SixLabors:master Dec 20, 2021
@br3aker br3aker deleted the dp/jpeg-sampling-factor-validation branch December 20, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal to remove non-complient images from Jpeg test suite and introduce new validation check

4 participants