Skip to content

Conversation

@br3aker
Copy link
Contributor

@br3aker br3aker commented Jul 16, 2021

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

@codecov
Copy link

codecov bot commented Jul 16, 2021

Codecov Report

Merging #1702 (9750014) into master (61b137d) will decrease coverage by 0.03%.
The diff coverage is 94.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1702      +/-   ##
==========================================
- Coverage   84.33%   84.29%   -0.04%     
==========================================
  Files         816      816              
  Lines       35914    35912       -2     
  Branches     4179     4181       +2     
==========================================
- Hits        30288    30273      -15     
- Misses       4806     4813       +7     
- Partials      820      826       +6     
Flag Coverage Δ
unittests 84.29% <94.95%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../Jpeg/Components/Decoder/JpegBlockPostProcessor.cs 100.00% <ø> (ø)
src/ImageSharp/Formats/Jpeg/JpegDecoderCore.cs 91.95% <92.18%> (-0.83%) ⬇️
...mats/Jpeg/Components/Decoder/HuffmanScanDecoder.cs 93.54% <95.83%> (-2.55%) ⬇️
...p/Formats/Jpeg/Components/Decoder/JpegComponent.cs 93.87% <100.00%> (-4.13%) ⬇️
...g/Components/Decoder/JpegComponentPostProcessor.cs 92.85% <100.00%> (+0.17%) ⬆️
...Sharp/Formats/Jpeg/Components/Decoder/JpegFrame.cs 100.00% <100.00%> (ø)
...eg/Components/Decoder/SpectralConverter{TPixel}.cs 100.00% <100.00%> (ø)
src/ImageSharp/Formats/Jpeg/JpegThrowHelper.cs 55.55% <0.00%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b137d...9750014. Read the comment docs.

Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff. Thanks!

@JimBobSquarePants JimBobSquarePants added this to the 1.1.0 milestone Jul 19, 2021
@JimBobSquarePants JimBobSquarePants merged commit ce2a28b into SixLabors:master Jul 19, 2021
@br3aker br3aker deleted the jpeg-decoder-refactoring branch July 19, 2021 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jpeg decoder IndexOutOfRangeException(s) with malformed images

3 participants