Run some high memory tests serial #1688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1688 +/- ##
=======================================
Coverage 84.33% 84.33%
=======================================
Files 816 816
Lines 35908 35908
Branches 4173 4173
=======================================
Hits 30282 30282
Misses 4804 4804
Partials 822 822
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
brianpopow
changed the title
JimBobSquarePants
approved these changes
Jul 5, 2021
Member
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Seems to be much more stable. Well done!
br3aker
reviewed
Jul 5, 2021
Comment on lines
-16
to
+17
| DebugGuard.MustBeBetweenOrEqualTo(start.X, 1, totalSize.Width - 1, nameof(start.X)); | ||
| DebugGuard.MustBeBetweenOrEqualTo(start.Y, 1, totalSize.Height - 1, nameof(start.Y)); | ||
| DebugGuard.MustBeBetweenOrEqualTo(start.X, 0, totalSize.Width - 1, nameof(start.X)); | ||
| DebugGuard.MustBeBetweenOrEqualTo(start.Y, 0, totalSize.Height - 1, nameof(start.Y)); |
Contributor
There was a problem hiding this comment.
Nice fix! Have no idea why I put 1 as lower border.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
We are seeing lately alot of OOM issues with the CI. This is an attempt to reduce the memory pressure by running high memory tests serial. This can be achieved by putting them in the same test collection with the attribute:
[Collection("RunSerial")]Since i have no better measure, what tests are using the most memory, i guessed the Encoder/Decoder tests are possible candidates, so i have put them in one Collection.