-
-
Notifications
You must be signed in to change notification settings - Fork 887
Fix coverage #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coverage #1094
Conversation
|
@JimBobSquarePants got and error on codecov upload |
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
===========================================
+ Coverage 65.21% 81.43% +16.22%
===========================================
Files 704 704
Lines 29311 29311
Branches 3290 3290
===========================================
+ Hits 19115 23870 +4755
+ Misses 9582 4748 -4834
- Partials 614 693 +79
Continue to review full report at Codecov.
|
|
@MarcoRossignoli That's fantastic thank you!
I'm actually going to go ahead and merge this. I'm keen to push on and the fix looks great. Thanks again! |
Didn't know if was your workflow idea. BTW good! This issue is the reason for us to move most user as possible to collectors, this bug is hard to discover and is related to very "small" behaviour changes. |
Test PR follow up coverlet-coverage/coverlet#700
This is a sample, it's not intended for merge.
I did some debugging and maybe found the issue(we'll see on this PR)
@antonfirsov PR add some out of process tests that slow down a bit the shutdown of test process, you're using msbuild that is affected by know issue https://github.com/tonerdo/coverlet/blob/master/Documentation/KnowIssues.md#1-vstest-stops-process-execution-earlydotnet-test
So new out of process tests create/update hits file(file where we put line/branch hit) on process exits but all other tests fail to log hits because vs test kill test process(the parent process of all other out of ones) before flush microsoft/vstest#1900 (comment)
This PR change the driver to collectors
BTW vstest has got a bug that I've fixed in microsoft/vstest#2221 but not yet released so you need for now to use the preview test sdk.
My local result

cc: @JimBobSquarePants