Harden memory-intensive tests, repurpose Sandbox46 #1089
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -216,7 +216,7 @@ artifacts/ | |
| *.csproj.bak | ||
|
|
||
| #CodeCoverage | ||
| *.lcov | ||
|
|
||
| # Tests | ||
| **/Images/ActualOutput | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,13 @@ | ||
| param( | ||
| [Parameter(Mandatory, Position = 0)] | ||
| [string]$version, | ||
| [Parameter(Mandatory = $true, Position = 1)] | ||
| [string]$targetFramework | ||
| ) | ||
|
|
||
| dotnet clean -c Release | ||
|
|
||
| $repositoryUrl = "https://github.com/$env:GITHUB_REPOSITORY" | ||
|
|
||
| # Building for a specific framework. | ||
| dotnet build -c Release -f $targetFramework /p:packageversion=$version /p:RepositoryUrl=$repositoryUrl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| param( | ||
| [Parameter(Mandatory, Position = 0)] | ||
| [string]$version | ||
| ) | ||
|
|
||
| dotnet clean -c Release | ||
|
|
||
| $repositoryUrl = "https://github.com/$env:GITHUB_REPOSITORY" | ||
|
|
||
| # Building for packing and publishing. | ||
| dotnet pack -c Release --output "$PSScriptRoot/artifacts" /p:packageversion=$version /p:RepositoryUrl=$repositoryUrl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| ## ImageSharp.Tests.ProfilingSandbox | ||
| Helper project to run and profile unit tests or other "sandbox" code from a single .exe entry point. |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| // Copyright (c) Six Labors and contributors. | ||
| // Licensed under the Apache License, Version 2.0. | ||
|
|
||
| using System.Runtime.CompilerServices; | ||
|
|
||
| [assembly:InternalsVisibleTo("ImageSharp.Tests.ProfilingSandbox")] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ | |
| using SixLabors.ImageSharp.ColorSpaces; | ||
| using SixLabors.ImageSharp.ColorSpaces.Conversion; | ||
| using Xunit; | ||
| using Xunit.Abstractions; | ||
|
|
||
| namespace SixLabors.ImageSharp.Tests.Colorspaces.Conversion | ||
| { | ||
|
|
@@ -21,6 +22,24 @@ public class RgbAndHslConversionTest | |
| private static readonly ColorSpaceConverter Converter = new ColorSpaceConverter(); | ||
| private static readonly ApproximateColorSpaceComparer ColorSpaceComparer = new ApproximateColorSpaceComparer(.0001F); | ||
|
|
||
| public static TheoryData<float, float, float, float, float, float> Hsl_To_Rgb | ||
| = new TheoryData<float, float, float, float, float, float> | ||
| { | ||
| { 0, 0, 0, 0, 0, 0 }, | ||
| { 0, 1, 1, 1, 1, 1 }, | ||
| { 360, 1, 1, 1, 1, 1 }, | ||
| { 0, 1, .5F, 1, 0, 0 }, | ||
| { 120, 1, .5F, 0, 1, 0 }, | ||
| { 240, 1, .5F, 0, 0, 1 } | ||
| }; | ||
|
|
||
| private readonly ITestOutputHelper output; | ||
|
|
||
| public RgbAndHslConversionTest(ITestOutputHelper output) | ||
| { | ||
| this.output = output; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Tests conversion from <see cref="Hsl"/> to <see cref="Rgb"/>. | ||
| /// </summary> | ||
|
|
@@ -31,6 +50,8 @@ public class RgbAndHslConversionTest | |
| [InlineData(0, 1, .5F, 1, 0, 0)] | ||
| [InlineData(120, 1, .5F, 0, 1, 0)] | ||
| [InlineData(240, 1, .5F, 0, 0, 1)] | ||
| //[Theory] | ||
|
Member
Author
There was a problem hiding this comment. Is this WIP stuff now here?
Member
There was a problem hiding this comment. It was just added to generate all the required info for coverlet-coverage/coverlet#700 I'll remove it |
||
| //[MemberData(nameof(Hsl_To_Rgb))] | ||
| public void Convert_Hsl_To_Rgb(float h, float s, float l, float r, float g, float b) | ||
| { | ||
| // Arrange | ||
|
|
@@ -54,6 +75,8 @@ public void Convert_Hsl_To_Rgb(float h, float s, float l, float r, float g, floa | |
| { | ||
| Assert.Equal(expected, actualSpan[i], ColorSpaceComparer); | ||
| } | ||
|
|
||
| this.output.WriteLine("Verifying Convert_Hsl_To_Rgb is run"); | ||
| } | ||
|
|
||
| /// <summary> | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.