Bokeh blur speedup and memory usage improvement #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated master from SixLabors/ImageSharp
Master cleanup (#952)
Changes from master
Changes from master
Latest changes from official master
Changes from master
Codecov Report
@@ Coverage Diff @@
## master #1058 +/- ##
==========================================
+ Coverage 89.9% 89.91% +0.01%
==========================================
Files 1131 1131
Lines 50654 50605 -49
Branches 3717 3713 -4
==========================================
- Hits 45539 45502 -37
+ Misses 4357 4347 -10
+ Partials 758 756 -2
Continue to review full report at Codecov.
|
JimBobSquarePants
approved these changes
Nov 27, 2019
Member
JimBobSquarePants
left a comment
JimBobSquarePants
left a comment
There was a problem hiding this comment.
Love it! Really nice optimization.
Member
Author
|
Wo-hooo! 😄🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This PR includes a refactoring of the bokeh blur effect, with a complete removal of the two "low memory usage" and "maximum performance" options, and a single implementation that is both faster than the previous "maximum performance", and uses less memory than the previous "low memory usage" mode. Basically, the best of both worlds, and even better than that! 🚀
Here's a benchmark with the 3 different modes. The images are of size 720, 1080 and 2160.
In particular:
ComplexVector4values, so that's a reduction ofsizeof(Vector4) 2 * imageHeight * imageWidthcompared to the "maximum performance" mode, and a reduction ofsizeof(Vector4) * 2 * kernelRadius * imageWidthcompared to the previous "low memory usage" mode. This is achieved by modifying the vertical convolution step so that the partial components of the fourier transformation for the bokeh kernels are directly added to the target processing buffer, which makes is possible to only use a temporary buffer for the results of the first horizontal 1D convolution pass.Parallel.Forinvocation on the entire image is not needed anymore. Additionally, this new implementation can always execute the code in parallel, unlike the previous "low memory usage" mode which was forced to execute the second 1D convolution sequentially, to be able to work on a shared buffer.@JimBobSquarePants @antonfirsov I think you'll be pretty happy with this new PR 😊
Also, please make sure that everything checks out on your end (all the checks are passing for me, so this should be easy to do) and merge this as soon as possible, since it includes a breaking change in a couple of exposed APIs, so it'd be better to do this while the lib is still in beta.