Skip to content

Conversation

@JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

  • Adds new AcceptVisitor extension method to the Advanced namespace and redirects all calls to that method.

Copy link
Member

@antonfirsov antonfirsov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark, otherwise looks good!

@codecov
Copy link

codecov bot commented Sep 17, 2019

Codecov Report

Merging #1010 into master will increase coverage by 0.11%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1010      +/-   ##
==========================================
+ Coverage   89.74%   89.86%   +0.11%     
==========================================
  Files        1098     1098              
  Lines       48828    48832       +4     
  Branches     3435     3435              
==========================================
+ Hits        43821    43881      +60     
+ Misses       4254     4249       -5     
+ Partials      753      702      -51
Impacted Files Coverage Δ
.../Processing/Processors/ImageProcessorExtensions.cs 100% <ø> (ø) ⬆️
...rocessing/Processors/Drawing/DrawImageProcessor.cs 100% <ø> (ø) ⬆️
src/ImageSharp/Image{TPixel}.cs 89.65% <0%> (ø) ⬆️
src/ImageSharp/Advanced/AdvancedImageExtensions.cs 93.33% <100%> (+0.47%) ⬆️
src/ImageSharp/Image.cs 93.54% <100%> (-0.21%) ⬇️
...harp/Processing/Extensions/ProcessingExtensions.cs 100% <100%> (ø) ⬆️
...files/ICC/DataWriter/IccDataWriter.TagDataEntry.cs 77.14% <0%> (ø) ⬆️
...ils/ReferenceImplementations.StandardIntegerDCT.cs 93.68% <0%> (ø) ⬆️
src/ImageSharp/Formats/Bmp/BmpDecoderCore.cs 94.36% <0%> (+0.17%) ⬆️
src/ImageSharp/Formats/Png/PngDecoderCore.cs 85.65% <0%> (+0.21%) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6f4f8e...ac4d71c. Read the comment docs.

@JimBobSquarePants JimBobSquarePants merged commit b004888 into master Sep 17, 2019
@JimBobSquarePants JimBobSquarePants deleted the feature/visitor branch September 17, 2019 23:59
antonfirsov pushed a commit to antonfirsov/ImageSharp that referenced this pull request Nov 11, 2019
Expose visitor through advanced namespace.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants