Skip to content

'Clear()' image operation - #43

Merged
tocsoft merged 5 commits into
masterfrom
sw/clear
May 6, 2020
Merged

tocsoft merged 5 commits into
masterfrom
sw/clear

Conversation

@tocsoft

@tocsoft tocsoft commented May 2, 2020

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Adds Clear(..) apis that will force the brush to overwrite the color of the destination image.

For most efficiency this works with #42 to create a fast path for most of the clear operations.

Fixes #41

Dependent on #39

@tocsoft tocsoft changed the title Sw/clear 'Clear()' image operation May 2, 2020
@tocsoft
tocsoft marked this pull request as ready for review May 4, 2020 17:16
@tocsoft
tocsoft requested a review from a team May 4, 2020 17:16

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the xml docs. Everything else looks great 👍

Comment thread src/ImageSharp.Drawing/Processing/Extensions/ClearExtensions.cs Outdated
Comment thread src/ImageSharp.Drawing/Processing/Extensions/ClearExtensions.cs Outdated
Comment thread src/ImageSharp.Drawing/Processing/Extensions/ClearPathExtensions.cs Outdated
Comment thread src/ImageSharp.Drawing/Processing/Extensions/ClearPathExtensions.cs Outdated
Comment thread src/ImageSharp.Drawing/Processing/Extensions/ClearPathExtensions.cs Outdated
Comment thread src/ImageSharp.Drawing/Processing/Extensions/ClearPathExtensions.cs Outdated

@JimBobSquarePants JimBobSquarePants left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Clear() methods to force drawing the provided color over a region

2 participants