Skip to content

Fix ImageBrush and DrawTextProcessor - #273

Merged
JimBobSquarePants merged 3 commits into
mainfrom
js/fix-270
May 5, 2023
Merged

JimBobSquarePants merged 3 commits into
mainfrom
js/fix-270

Conversation

@JimBobSquarePants

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #270

@JimBobSquarePants
JimBobSquarePants requested a review from tocsoft May 5, 2023 10:09
@JimBobSquarePants JimBobSquarePants added the bug Something isn't working label May 5, 2023
@JimBobSquarePants JimBobSquarePants added this to the 1.0.0 milestone May 5, 2023
@codecov

codecov Bot commented May 5, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #273 (1b25598) into main (626900c) will not change coverage.
The diff coverage is 0%.

@@         Coverage Diff         @@
##           main   #273   +/-   ##
===================================
  Coverage    78%    78%           
===================================
  Files        97     97           
  Lines      5067   5067           
  Branches    932    932           
===================================
  Hits       3985   3985           
  Misses      898    898           
  Partials    184    184           
Flag Coverage Δ
unittests 78% <0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ImageSharp.Drawing/Processing/ImageBrush.cs 82% <0%> (ø)
...ssing/Processors/Text/DrawTextProcessor{TPixel}.cs 80% <0%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JimBobSquarePants JimBobSquarePants changed the title Fix ImageBruh and DrawTextProcessor Fix ImageBrush and DrawTextProcessor May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ImageBrushApplicator indexer appears to have a bug, accessing the Width property instead of Height (ImageBrush.cs, line 140)

3 participants