Skip to content

Update dependencies and normalize namespace - #25

Merged
JimBobSquarePants merged 2 commits into
masterfrom
js/fix-namespace
Jan 20, 2020
Merged

JimBobSquarePants merged 2 commits into
masterfrom
js/fix-namespace

Conversation

@JimBobSquarePants

Copy link
Copy Markdown
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

  • Updates Fonts
  • Update ImageSharp
  • Normalize namespace to use SixLabors.ImageSharp as the base throughout.

@codecov

codecov Bot commented Jan 20, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #25 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #25   +/-   ##
=======================================
  Coverage   68.47%   68.47%           
=======================================
  Files          66       66           
  Lines        4951     4951           
=======================================
  Hits         3390     3390           
  Misses       1561     1561
Flag Coverage Δ
#unittests 68.47% <0%> (ø) ⬆️
Impacted Files Coverage Δ
src/ImageSharp.Drawing/Processing/SolidBrush.cs 95% <ø> (ø) ⬆️
...ageSharp.Drawing/Processing/RadialGradientBrush.cs 100% <ø> (ø) ⬆️
...rc/ImageSharp.Drawing/Processing/DrawingHelpers.cs 100% <ø> (ø) ⬆️
src/ImageSharp.Drawing/Shapes/Path.cs 71.79% <ø> (ø) ⬆️
...cessing/Extensions/FillPathCollectionExtensions.cs 100% <ø> (ø) ⬆️
src/ImageSharp.Drawing/Shapes/EllipsePolygon.cs 84.05% <ø> (ø) ⬆️
...arp.Drawing/Shapes/PolygonClipper/ClippablePath.cs 0% <ø> (ø) ⬆️
...rawing/Processing/Extensions/DrawPathExtensions.cs 66.66% <ø> (ø) ⬆️
...ageSharp.Drawing/Shapes/Helpers/ArrayExtensions.cs 87.5% <ø> (ø) ⬆️
...rawing/Processing/Extensions/DrawTextExtensions.cs 100% <ø> (ø) ⬆️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc978b...88a73c3. Read the comment docs.

@tocsoft tocsoft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine just the small issue of duplicate InternalsVisibleTo

Comment thread src/ImageSharp.Drawing/ImageSharp.Drawing.csproj Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants