Repository navigation
Return empty path when outline width is less than or equal to zero - #225
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #225 +/- ##
===================================
Coverage 71% 71%
===================================
Files 87 88 +1
Lines 5349 5362 +13
Branches 1094 1096 +2
===================================
+ Hits 3835 3845 +10
- Misses 1295 1298 +3
Partials 219 219
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Updates the
GenerateOutlineextensions so that when an invalid width (<= 0) is specified that instead of looping it returns anEmptyPath(a new type to represent an empty path without addition allocations).This resolves #224