Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Initializers] Add merge (concatenate) functionality for .env files #952

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Mar 16, 2022

Description / Motivation

Allow add-on initializers to define only environment variables specific to the add-on. Currently, this is a simple file concatenation, which allows preservation of comments and whitespace. This means it's not possible to override existing values; however, this hasn't been identified as a use case.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team March 16, 2022 19:10
@vercel
Copy link

vercel bot commented Mar 16, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/3HsCidyYpDxj1hwhVZRD7QktiZQe
✅ Preview: Failed

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved 👍

@illiakovalenko illiakovalenko merged commit 080fc79 into dev Mar 17, 2022
@illiakovalenko illiakovalenko deleted the feature/522564-env-merge branch March 17, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants