Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Initializer] Personalize Initializer Add-on #939

Merged
merged 17 commits into from
Mar 4, 2022

Conversation

sc-addypathania
Copy link
Contributor

@sc-addypathania sc-addypathania commented Mar 2, 2022

Transferred the Personalize nextjs POC work.

Description / Motivation

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-addypathania sc-addypathania requested a review from a team March 2, 2022 22:47
@vercel
Copy link

vercel bot commented Mar 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/3QFgJ9ekKpC7bRfWB7Q2cCJ1gnQb
✅ Preview: Failed

[Deployment for 038b601 failed]

@sc-addypathania sc-addypathania changed the title [Initializer] Personalizer Initializer Add-on [Initializer] Personalize Initializer Add-on Mar 3, 2022
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Beyond this, I'm seeing a lot of files that are OOTB with either the base or nextjs-styleguide add-on initializers. Any of those should be removed here.

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ambrauer ambrauer merged commit 996d72e into dev Mar 4, 2022
@ambrauer ambrauer deleted the feature/nextjs-personalize-add-on branch March 4, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants