Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Initializers] Restore sub-command (npm install / lint) console output #933

Merged
merged 5 commits into from
Feb 16, 2022
Merged

[Initializers] Restore sub-command (npm install / lint) console output #933

merged 5 commits into from
Feb 16, 2022

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

We moved away from inherit for stdio in #912 to address an issue with the npm install hanging when run within our dotnet template for Next.js. However, this resulted in a loss of useful output. This PR goes back to using inherit for stdio w/ fallback to pipe (when not TTY context).

Testing Details

Tested on Node.js LTS (16.10), including within dotnet template for Next.js

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team February 15, 2022 20:04
@vercel
Copy link

vercel bot commented Feb 15, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/H4yPgSDs2okZVpAdEq7WwiASaZd1
✅ Preview: Failed

[Deployment for faac5d3 failed]

sc-addypathania
sc-addypathania reviewed Feb 16, 2022
View reviewed changes
Copy link
Contributor

@sc-addypathania sc-addypathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing.

@ambrauer
Copy link
Contributor Author

Some tests are failing.

@sc-addypathania Thanks for letting me know, tests are now passing on CI.

sc-addypathania
sc-addypathania approved these changes Feb 16, 2022
View reviewed changes
Copy link
Contributor

@sc-addypathania sc-addypathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@ambrauer ambrauer merged commit 46618bc into dev Feb 16, 2022
@ambrauer ambrauer deleted the fix/519082-cmd-output branch February 16, 2022 19:02
ambrauer added a commit that referenced this pull request Feb 16, 2022
@ambrauer
[Initializers] Restore sub-command (npm install / lint) console output (
88bf81d 
#933)

* Add missing 'silent' pass-through to lint command

* Restore sub-command output for npm install / lint, by using 'inherit' for stdio w/ fallback to 'pipe' (when not TTY context)

* Fix failing tests on CI

* Fixed / expanded tests

* updated yarn.lock

(cherry picked from commit 46618bc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc-addypathania sc-addypathania sc-addypathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ambrauer @sc-addypathania