Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] Use more focused paths for Sitecore rewrites #921

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Feb 3, 2022

Description / Motivation

Use more focused paths for Sitecore rewrites (similar to RAV / headless proxy) to avoid interference with allowed path "/sitecore/templates". This fixes an issue which prevented template standard values from being edited in Sitecore.

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

…/ headless proxy) to avoid interference with allowed path "/sitecore/templates". This fixes an issue which prevented template standard values from being edited in Sitecore.
@ambrauer ambrauer requested a review from a team February 3, 2022 14:00
@vercel
Copy link

vercel bot commented Feb 3, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/D6poC5DFCF16kSfFi3CiW1kkMQHq
✅ Preview: Failed

Copy link
Contributor

@sc-addypathania sc-addypathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@ambrauer ambrauer merged commit cceda0c into dev Feb 4, 2022
@ambrauer ambrauer deleted the fix/512685 branch February 4, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants