Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAV] Bring environment variable support to config generation #911

Merged
merged 3 commits into from
Jan 19, 2022
Merged

[RAV] Bring environment variable support to config generation #911

merged 3 commits into from
Jan 19, 2022

Conversation

ambrauer
Copy link
Contributor

Description / Motivation

  • [RAV] Allow environment variables to drive config values, similar to functionality already in Next.js template.
  • [React] Also, complete migration to Apollo Client 3 (remove usage of apollo-client and react-apollo)

Testing Details

Manually tested bootstrap + disconnected start for RAV apps.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team January 19, 2022 13:38
@vercel
Copy link

vercel bot commented Jan 19, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/BSTfcUAMEg6NQGUp8yn9Bw5hN5wh
✅ Preview: Failed

[Deployment for 5445434 failed]

illiakovalenko
illiakovalenko requested changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Only one comment to remove an extra log

packages/create-sitecore-jss/src/templates/react/src/lib/GraphQLData.js Outdated Show resolved Hide resolved
@ambrauer ambrauer merged commit 96eaccc into dev Jan 19, 2022
@ambrauer ambrauer deleted the fix/515132 branch January 19, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illiakovalenko illiakovalenko illiakovalenko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ambrauer @illiakovalenko