Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade security vulnerable packages #866

Merged
merged 2 commits into from
Dec 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/sitecore-jss-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"readline-sync": "^1.4.10",
"resolve": "^1.12.0",
"tmp": "^0.1.0",
"yargs": "^14.0.0"
"yargs": "^17.3.0"
},
"devDependencies": {
"@types/chai": "^4.2.3",
Expand All @@ -58,7 +58,7 @@
"@types/resolve": "^0.0.8",
"@types/sinon": "^7.5.0",
"@types/tmp": "^0.1.0",
"@types/yargs": "^13.0.3",
"@types/yargs": "^17.0.7",
"chai": "^4.2.0",
"cross-env": "^6.0.3",
"del-cli": "^3.0.1",
Expand Down
6 changes: 3 additions & 3 deletions packages/sitecore-jss-cli/src/cli-shared.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ process.on('unhandledRejection', (err) => {
/**
* @param {any} commands
*/
export default function cli(commands: {
export default async function cli(commands: {
[key: string]: CommandModule & { disableStrictArgs?: boolean };
}) {
let appCommands = yargs.usage('$0 <command>');
Expand All @@ -26,7 +26,7 @@ export default function cli(commands: {
// command is a yargs builder function that takes a yargs and returns a yargs
// YARRRRRGS :D
if (typeof commandObject.builder === 'function') {
appCommands = commandObject.builder(appCommands);
appCommands = await commandObject.builder(appCommands);
}

// command is a yargs 'command module' (https://github.com/yargs/yargs/blob/master/docs/advanced.md#providing-a-command-module)
Expand All @@ -44,7 +44,7 @@ export default function cli(commands: {
}
}

const argv = appCommands.demandCommand(1).help().argv;
const argv = await appCommands.demandCommand(1).help().argv;

if (!argv._[0]) {
console.log('Missing command. Use --help to see all available options.');
Expand Down
6 changes: 3 additions & 3 deletions packages/sitecore-jss-dev-tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@sitecore-jss/sitecore-jss": "^20.0.0-canary.76",
"axios": "^0.21.1",
"chokidar": "^3.2.1",
"del": "^5.1.0",
"del": "^6.0.0",
"express": "^4.17.1",
"form-data": "^3.0.0",
"fs-extra": "^8.1.0",
Expand All @@ -50,7 +50,7 @@
"ts-node": "^8.4.1",
"url-join": "^4.0.1",
"uuid": "^8.3.2",
"yargs": "^14.0.0"
"yargs": "^17.3.0"
},
"devDependencies": {
"@types/chai": "^4.2.3",
Expand All @@ -69,7 +69,7 @@
"@types/sinon": "^7.5.0",
"@types/url-join": "^4.0.0",
"@types/uuid": "^8.3.3",
"@types/yargs": "^12.0.1",
"@types/yargs": "^17.0.7",
"babel-core": "^6.26.3",
"chai": "^4.2.0",
"chalk": "^2.4.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/sitecore-jss-rendering-host/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"dependencies": {
"del": "^5.1.0",
"import-fresh": "^3.1.0",
"ngrok": "^3.2.5",
"ngrok": "^4.2.2",
"opn": "^6.0.0",
"webpack": "4.41.0",
"webpack-dev-server": "3.11.0"
Expand Down
8 changes: 4 additions & 4 deletions packages/sitecore-jss-rendering-host/src/tunnel.ts
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
import ngrok, { INgrokOptions } from 'ngrok';
import ngrok, { Ngrok } from 'ngrok';

export interface TunnelOptions extends INgrokOptions {
export interface TunnelOptions extends Ngrok.Options {
port?: number;
quiet?: boolean;
}

/**
* @param {string} renderHostname
* @param {INgrokOptions} options
* @param {Ngrok.Options} options
*/
export function startRenderHostTunnel(
renderHostname: string,
options: INgrokOptions = { port: 80, proto: 'http', quiet: false }
options: Ngrok.Options = { port: 80, proto: 'http', quiet: false }
) {
if (!renderHostname) {
throw new Error(
Expand Down
2 changes: 1 addition & 1 deletion samples/nextjs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"graphql": "~15.4.0",
"graphql-tag": "^2.11.0",
"next": "^12.0.4",
"next-localization": "^0.10.0",
"next-localization": "^0.11.0",
"nprogress": "~0.2.0",
"react": "^17.0.2",
"react-dom": "^17.0.2"
Expand Down
Loading