[Angular] The page is redirected to the home page of the website after clicking the "Change associated content" button in the Experience Editor in angular application #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/gp6b1hEk7ae8YmkAzuEfncongeSc |
ambrauer
approved these changes
Oct 19, 2021
illiakovalenko
requested changes
Oct 20, 2021
sc-addypathania
approved these changes
Oct 20, 2021
- Use ExperienceEditor class for active editor check - Change null check for targetNode
CobyPear
added a commit
that referenced
this pull request
Oct 21, 2021
…r clicking the "Change associated content" button in the Experience Editor in angular application (#835) * Add workaround for Angular not handling EE onclick * Change import to angluar pkg * Move code to utils in angular package * Add comment to sample * Refactor based on comments * More refactoring - Use ExperienceEditor class for active editor check - Change null check for targetNode * Use isExperienceEditorActive method for release/18.0.0 branch (cherry picked from commit 103b7a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Angular treats anchor tags with href attributes as links and ignores any onclick handlers that may be present on the element in favor of navigating to the href.
Add a workaround so that when using the Experience Editor, Angular properly executes the onclick provided by Experience Editor instead of routing to the href.
Description / Motivation
Experience Editor dropdown buttons were not functioning as expected in the Angular sample app
Testing Details
Check markup in Experience Editor, click on button to see it now behaves as expected
Types of changes
/docsdirectory)