[Angular] *scRouterLink breaks link generation #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/DDx3SeAv2YamNmyJ2PmUoaNncsXN [Deployment for 4fe403c failed] |
ambrauer
approved these changes
Sep 16, 2021
packages/sitecore-jss-angular/src/components/router-link.directive.spec.ts
Outdated
Show resolved
Hide resolved
ambrauer
approved these changes
Sep 16, 2021
CobyPear
added a commit
that referenced
this pull request
Sep 16, 2021
* Strip querystring params from ScRouterLink href * Update tests for router-link * Use navigateByUrl instead
CobyPear
added a commit
that referenced
this pull request
Sep 16, 2021
* Strip querystring params from ScRouterLink href * Update tests for router-link * Use navigateByUrl instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with SXA, this Angular component will add querystring params to the end of the
hrefof the link, for example/testbecomes/test?sc_site=this-sitename. This PR adds a tested function that strips the querystring params off of the intended path, resulting in correct client side routing.Limitations of this component include being unable to access an external link, for such scenarios please use *scLink
Description / Motivation
Hotfix request
Testing Details
Tested on SC 10.2 with JSS 20 and SC 10.0 with JSS 16 + SXA
Types of changes
/docsdirectory)