Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAV] Include Sitecore server URL in media URLs by default (regression) #802

Merged
merged 1 commit into from
Sep 7, 2021
Merged

[RAV] Include Sitecore server URL in media URLs by default (regression) #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 0 additions & 26 deletions samples/angular/sitecore/config/JssAngularWeb.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,31 +86,5 @@
</styleguide-image-sample-adaptive>
</allowedMediaParams>
</javaScriptServices>
<!--
Media URLs resolving
Tells Sitecore to not include the Sitecore server URL as part of the media requests, so that they are instead routed through Next.js rewrites (see next.config.js).
This eliminates exposing the Sitecore server publicly.

"default" configuration is used for Sitecore GraphQL Edge requests.
"jss" configuration is used for Sitecore Layout Service REST requests.
-->
<layoutService>
<configurations>
<config name="default">
<rendering>
<renderingContentsResolver>
<IncludeServerUrlInMediaUrls>false</IncludeServerUrlInMediaUrls>
</renderingContentsResolver>
</rendering>
</config>
<config name="jss">
<rendering>
<renderingContentsResolver>
<IncludeServerUrlInMediaUrls>false</IncludeServerUrlInMediaUrls>
</renderingContentsResolver>
</rendering>
</config>
</configurations>
</layoutService>
</sitecore>
</configuration>
26 changes: 0 additions & 26 deletions samples/react/sitecore/config/JssReactWeb.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,31 +86,5 @@
</styleguide-image-sample-adaptive>
</allowedMediaParams>
</javaScriptServices>
<!--
Media URLs resolving
Tells Sitecore to not include the Sitecore server URL as part of the media requests, so that they are instead routed through Next.js rewrites (see next.config.js).
This eliminates exposing the Sitecore server publicly.

"default" configuration is used for Sitecore GraphQL Edge requests.
"jss" configuration is used for Sitecore Layout Service REST requests.
-->
<layoutService>
<configurations>
<config name="default">
<rendering>
<renderingContentsResolver>
<IncludeServerUrlInMediaUrls>false</IncludeServerUrlInMediaUrls>
</renderingContentsResolver>
</rendering>
</config>
<config name="jss">
<rendering>
<renderingContentsResolver>
<IncludeServerUrlInMediaUrls>false</IncludeServerUrlInMediaUrls>
</renderingContentsResolver>
</rendering>
</config>
</configurations>
</layoutService>
</sitecore>
</configuration>
26 changes: 0 additions & 26 deletions samples/vue/sitecore/config/JssVueWeb.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,31 +85,5 @@
</styleguide-image-sample-adaptive>
</allowedMediaParams>
</javaScriptServices>
<!--
Media URLs resolving
Tells Sitecore to not include the Sitecore server URL as part of the media requests, so that they are instead routed through Next.js rewrites (see next.config.js).
This eliminates exposing the Sitecore server publicly.

"default" configuration is used for Sitecore GraphQL Edge requests.
"jss" configuration is used for Sitecore Layout Service REST requests.
-->
<layoutService>
<configurations>
<config name="default">
<rendering>
<renderingContentsResolver>
<IncludeServerUrlInMediaUrls>false</IncludeServerUrlInMediaUrls>
</renderingContentsResolver>
</rendering>
</config>
<config name="jss">
<rendering>
<renderingContentsResolver>
<IncludeServerUrlInMediaUrls>false</IncludeServerUrlInMediaUrls>
</renderingContentsResolver>
</rendering>
</config>
</configurations>
</layoutService>
</sitecore>
</configuration>