Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Angular] Language is not preserved when navigating to another page #793

Merged
merged 5 commits into from
Sep 1, 2021

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Aug 20, 2021

Description / Motivation

  1. Create new jss app for selected framework (angular in this case): 'jss create angular-app angular --fetchWith REST -b release/18.0.0'
  2. Create API KEY in the Sitecore instance
  3. Run 'jss setup' to confogure app
  4. Deploy configs to the Sitecore instance
  5. Add da-DK language to the Sitecore instance
  6. Deploy items for en and da-DK languages: 'jss deploy items -c -d', 'jss deploy items -c -d language da-DK'
  7. Deploy app: jss deploy app -c -d
  8. Run command: jss start:connected
  9. Open page: http://localhost:3000/styleguide
  10. Click 'Show in Danish' link
  11. Click 'GraphQL' link in the header

AR: 'GraphQL' page is opened in english language
ER: 'GraphQL' page is opened in danish language (empty page should be shown in our case since we don't have english version for it)

Testing Details

  • CSR
  • SSR

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

@vercel
Copy link

vercel bot commented Aug 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sitecore-jss/edge-e2e-styleguide/DDAMCGDZoXdyUNP4JkJWArpcVPzN
✅ Preview: https://edge-e2e-styleguide-git-feature-485363-sitecore-jss.vercel.app

Copy link
Contributor

@CobyPear CobyPear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me besides a few comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants