Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature/459416] [sitecore-jss-cli] implemented .env handling for CLI #542

Merged
merged 6 commits into from
Jan 27, 2021
Merged

[Feature/459416] [sitecore-jss-cli] implemented .env handling for CLI #542

merged 6 commits into from
Jan 27, 2021

Conversation

nickwesselman
Copy link
Contributor

Description

  • primarily to support NODE_EXTRA_CA_CERTS
  • with behavior and capabilities close to those of Next.js
  • includes hidden jss environment --name FOO command for debugging

Motivation

Primarily to support NODE_EXTRA_CA_CERTS. In the Next.js getting started template, I want to populate this in .env.local with the mkcert root.

How Has This Been Tested?

  • Unit tests
  • Newly added (hidden) CLI command

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update (non-breaking change; modified files are limited to the /docs directory)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My code/comments/docs fully adhere to the Code of Conduct.
  • My change is a code change and it requires an update to the documentation.
  • My change is a documentation change and it requires an update to the navigation.

@nickwesselman
implemented .env handling for CLI
09f0940 
* primarily to support NODE_EXTRA_CA_CERTS
* with behavior and capabilities close to those of Next.js
* includes hidden `jss environment --name FOO` command for debugging
ambrauer
ambrauer approved these changes Jan 27, 2021
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice addition to CLI

@nickwesselman
don't process mode .env files without a NODE_ENV
7e5d754 
* change based on follow up discussion with @anastasiya29
@nickwesselman nickwesselman merged commit 82928a8 into dev Jan 27, 2021
@nickwesselman nickwesselman deleted the feature/459416/cli-dotenv-support branch January 27, 2021 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

@anastasiya29 anastasiya29 anastasiya29 approved these changes

@illiakovalenko illiakovalenko Awaiting requested review from illiakovalenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nickwesselman @ambrauer @anastasiya29