Fix prop-types for missingComponentComponent to allow a functional component #459
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Placeholder.test.tsx
that checks the case when an unknown component is requested for rendering -> then the passedmissingComponentComponent
prop of thePlaceholder
should be used.missingComponentComponent
prop as it currently allows only objects while it should allow a functionMotivation
When a custom
MissingComponent
implementation is passed to themissingComponentComponent
prop there is a runtime error sayingFailed prop type: Invalid prop missingComponentComponent supplied to PlaceholderComponent.
This is because the prop-types are incorrect and don't allow a function.
How Has This Been Tested?
I have added a test case that is using the missingComponentComponent prop and when this test is ran with the old prop-types then the runtime error is reproduced.
When prop-types allow for a
func
the runtime error disappears.Types of changes
/docs
directory)Checklist: