Fixes withSitecoreContext typescript definition #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-illiakovalenko
added a commit
that referenced
this pull request
Jul 27, 2020
* Fix bug #349 typings for Placeholder prop functions render, renderEach, renderEmpty (#350) * Fixes withSitecoreContext typescript definition (#347) * v14.0.0 * [React sample] Cannot read property 'fields' of undefined * [React sample] version fix * v14.0.1 * [Doc] Remove mentioning that Sitecore JSS Forms are not working in headless mode + provide workaround
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current typescript definition is forcing the component to have props of type
ComponentConsumerPropsinstead of just forcing to extend that type.Motivation
Components should be able use more properties that the ones just on
ComponentConsumerProps, this fixes thatHow Has This Been Tested?
Typescript doesn't complain any more and tests pass. Assuming that users are actually including the context properties in their component props, there should be no impact.
Types of changes
Checklist: