React sample - set i18n init lang to prevent SSR hydration from re-rendering app #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set i18n initial language based on SSR language or static config defaultLanguage to prevent re-renders in multi-lingual apps during the hydration process.
Motivation
To fix the flicker after initial page load issue when using the React sample. (This issue may exist in the other samples as well.)
How Has This Been Tested?
I have tested local Sitecore 9.3 instance with a JSS 13.0 site and debug via chrome dev tools.
My change simply initializes the language for i18ninit by pulling the SSR language from JSS_STATE, or using the config defaultLanguage setting.
The comments in code seem to support this, but I feel this could be introduced to prevent others from experiencing this issue OOTB.
Types of changes
Checklist: