[Editing Integration] Integrate /editing/render endpoint #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illiakovalenko
commented
May 30, 2024
packages/create-sitecore-jss/src/templates/nextjs/src/lib/next-config/plugins/cors-header.js
Show resolved
Hide resolved
illiakovalenko
commented
May 30, 2024
| @@ -83,7 +87,7 @@ export type GraphQLRequestClientConfig = { | |||
| * @returns An instance of a GraphQL Request Client ready to send GraphQL requests. | |||
| */ | |||
| export type GraphQLRequestClientFactory = ( | |||
| config: Omit<GraphQLRequestClientConfig, 'apiKey'> | |||
| config?: Omit<GraphQLRequestClientConfig, 'apiKey'> | |||
There was a problem hiding this comment.
NOTE: made config argument optional since initially it didn't match the interface we have here
ambrauer
reviewed
May 30, 2024
...sitecore-jss/src/templates/nextjs-xmcloud/src/lib/page-props-factory/plugins/preview-mode.ts
Outdated
Show resolved
Hide resolved
...sitecore-jss/src/templates/nextjs-xmcloud/src/lib/page-props-factory/plugins/preview-mode.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-data-service.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/lib/next-config/plugins/cors-header.js
Show resolved
Hide resolved
sc-addypathania
approved these changes
Jun 2, 2024
art-alexeyenko
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
[next.js]Integrated a new Metadata Edit Mode in /api/editing/render endpoint.EditingMetadataPreviewDatatype andisEditingMetadataPreviewDataguard function.GraphQLEditingServiceclass to fetch editing data in Metadata Edit Mode.[sitecore-jss]Introduced /editing submodule that contains all editing related functionality. Editing utils are now available in /editing submodule. Editing utils exported from /utils marked as deprecated.GraphQLRequestClientnow can accept custom 'headers' in the constructor or via createClientFactoryTesting Details
Types of changes