Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ability for manifest media to be extracted from inherited template fields. #175

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Added ability for manifest media to be extracted from inherited template fields. #175

merged 1 commit into from
Apr 18, 2019

Conversation

aweber1
Copy link
Contributor

@aweber1 aweber1 commented Apr 17, 2019

Fixes #174

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the Contributing guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.

@aweber1
Added method to recursively resolve fields from all inherited templat…
53f13e6 
…es and ancestors. Allows the buildMediaOutput function to properly inspect all template fields (including inherited fields) when extracting image/file field values.
@aweber1 aweber1 requested a review from kamsar April 17, 2019 21:10
@aweber1 aweber1 merged commit 73241e5 into dev Apr 18, 2019
@aweber1 aweber1 deleted the issue/174-manifest-media-inherited-templates branch April 18, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamsar kamsar kamsar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manifest doesn't recognize or emit media files for inherited templates.
2 participants
@aweber1 @kamsar