Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next] Upgrade to version 14 #1720

Merged
merged 3 commits into from
Jan 22, 2024
Merged

[Next] Upgrade to version 14 #1720

merged 3 commits into from
Jan 22, 2024

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Jan 22, 2024 •
edited
Loading

Description / Motivation

No breaking changes related to functionality within the upgrade

Testing Details

  • Unit Test Added
  • Manual Test/Other - smoke testing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team January 22, 2024 02:52
art-alexeyenko
art-alexeyenko approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I would maybe just rephrase this part (this should have pointed to release notes, not sure why the link disappeared) . Something like "Due to changes in peer dependencies, please ensure your app uses nextjs version 14", for better clarity.

@illiakovalenko illiakovalenko merged commit f02e49a into dev Jan 22, 2024
1 check was pending
@illiakovalenko illiakovalenko deleted the feature/JSS-1322 branch January 22, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@art-alexeyenko art-alexeyenko art-alexeyenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illiakovalenko @art-alexeyenko