Changed proptypes in PlaceholderCommon #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed proptypes of
missingComponentComponent
anderrorComponent
toPropTypes.func
inpackages/sitecore-jss-react/src/components/PlaceholderCommon.tsx
Motivation
Whenever the following JSX is used:
The following warning will occur:
This PR will stop that warning from showing
How Has This Been Tested?
I've changed the proptypes and made sure the warning did not show up in my browser-console.
Browser: Chrome Version 73.0.3683.86 (Official Build) (64-bit)
OS: OSX
Types of changes
Checklist: