Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss] Load content styles using a correct file proxy url #1683

Merged
merged 2 commits into from
Dec 4, 2023
Merged

[sitecore-jss] Load content styles using a correct file proxy url #1683

merged 2 commits into from
Dec 4, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Dec 4, 2023 •
edited
Loading

Description / Motivation

  • Updated styles url to use file proxy path

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

ambrauer
ambrauer approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update CHANGELOG, otherwise 👍

@illiakovalenko
Copy link
Contributor Author

@ambrauer Yeah, just wanted to update :)

@illiakovalenko illiakovalenko merged commit 78bc3d7 into dev Dec 4, 2023
1 check was pending
@illiakovalenko illiakovalenko deleted the bugfix/JSS-956-fix-url branch December 4, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illiakovalenko @ambrauer