Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sitecore-jss-react] Use ComponentDataOverride instead of ComponentProps for BYOCComponent #1682

Merged
merged 2 commits into from
Dec 6, 2023
Merged

[sitecore-jss-react] Use ComponentDataOverride instead of ComponentProps for BYOCComponent #1682

merged 2 commits into from
Dec 6, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Dec 4, 2023 •
edited
Loading

Description / Motivation

  • Use ComponentDataOverride instead of ComponentProps for BYOCComponent

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team December 4, 2023 13:48
sc-addypathania
sc-addypathania approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@sc-addypathania sc-addypathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼

@sc-addypathania sc-addypathania merged commit 3a9fb8b into dev Dec 6, 2023
1 check passed
@sc-addypathania sc-addypathania deleted the bugfix/JSS-1316 branch December 6, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc-addypathania sc-addypathania sc-addypathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illiakovalenko @sc-addypathania