Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Next.js] Use Edge Platform file proxy for FEaaS stylesheets #1666

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

ambrauer
Copy link
Contributor

@ambrauer ambrauer commented Nov 16, 2023

Description / Motivation

Use Edge Platform file proxy for FEaaS stylesheets. This replaces both the CDN URL (#1645) and staged/published (#1644) determination we used previously. These are now determined by the Edge Platform environment and Context ID (Preview vs Live), respectively.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@ambrauer ambrauer requested a review from a team November 16, 2023 23:34
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@illiakovalenko illiakovalenko merged commit 2e88122 into dev Nov 17, 2023
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-995 branch November 17, 2023 11:37
ambrauer added a commit that referenced this pull request Nov 22, 2023
* Use edge file proxy for FEaaS stylesheets

* updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants