[Nextjs] Allow empty string for getPublicUrl #1656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrauer
requested changes
Nov 9, 2023
packages/create-sitecore-jss/src/templates/nextjs/scripts/generate-config.ts
Outdated
Show resolved
Hide resolved
…tlify env vars; adjust unit tests
…fig and in config fallback plugin
ambrauer
reviewed
Nov 13, 2023
Co-authored-by: Adam Brauer <[email protected]>
…nv variable; adjust unit tests
ambrauer
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Bit of scope increase, but now that we have the publicUrl available on the JSS config, I think we should switch over to use it exclusively in the app template (vs calling getPublicUrl() everywhere).
Here are the locations:
https://github.com/search?q=repo%3ASitecore%2Fjss+getPublicUrl%28%29+path%3A%2F%5Epackages%5C%2Fcreate-sitecore-jss%5C%2Fsrc%5C%2Ftemplates%5C%2F%2F&type=code
ambrauer
approved these changes
Nov 15, 2023
packages/create-sitecore-jss/src/templates/nextjs-styleguide-tracking/src/Navigation.tsx
Outdated
Show resolved
Hide resolved
illiakovalenko
requested changes
Nov 16, 2023
| @@ -58,7 +57,7 @@ const sitemapApi = async ( | |||
| const lastSegment = parseUrl[parseUrl.length - 1]; | |||
|
|
|||
| return `<sitemap> | |||
| <loc>${getPublicUrl()}/${lastSegment}</loc> | |||
| <loc>${config.publicUrl}/${lastSegment}</loc> | |||
There was a problem hiding this comment.
@matkovskyi can you verify if using empty string breaks your functionality?
There was a problem hiding this comment.
@kendoce Yes, an empty string can't be used here
…l, which can be empty
ambrauer
reviewed
Nov 22, 2023
| @@ -50,14 +50,16 @@ const sitemapApi = async ( | |||
| if (!sitemaps.length) { | |||
| return res.redirect('/404'); | |||
| } | |||
|
|
|||
|
|
|||
| const reqtHost = req.headers.host; | |||
There was a problem hiding this comment.
Will this handle localhost?
ambrauer
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
In production non editing environments, it is desirable to use relative URLs for static assets (e.g. _next/*, images, etc). For this we need to allow for the PUBLIC_URL environment variable to be set as empty string - comment the PUBLIC_URL in the default .env; adjust the logic in the getPublicUrl() function so that empty string is not treated as wrong and also takes precedence over vercel and netlify variables.
Connected with that this PR addresses a specific scenario where in editing environment a component makes a call to a nextjs app api route, which fails because we don't have access to PUBLIC_URL on the client side.
Testing Details
Types of changes