Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#600951: [templates/nextjs] fixed plugin of cors header #1637

Merged
merged 5 commits into from
Oct 26, 2023

Conversation

matkovskyi
Copy link
Collaborator

@matkovskyi matkovskyi commented Oct 25, 2023

Description / Motivation

Problem was with custom headers. There was missed extends common nextjs config of headers

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise 👍

@illiakovalenko illiakovalenko merged commit ddd4137 into dev Oct 26, 2023
1 check passed
@illiakovalenko illiakovalenko deleted the bugfix/600951-custom-headers branch October 26, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants