Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss-proxy] setting "followRedirects" to "true" breaks HEAD requests - fix for v20 #1635

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Oct 19, 2023

Description / Motivation

When customers use followRedirects: true and try to send a HEAD request, the proxy server crashes.
This PR contains modified version of the changes introduced in PR #1630 , for v.20

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏼

@yavorsk yavorsk merged commit 46959d1 into release/20.0.0 Oct 19, 2023
1 check passed
@yavorsk yavorsk deleted the bugfix/JSS-788 branch October 19, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants