Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates/nextjs][templates/nextjs-sxa] Extend retrier to ErrorPagesService and make it configurable through env #1619

Merged
merged 5 commits into from
Sep 27, 2023
Merged

[templates/nextjs][templates/nextjs-sxa] Extend retrier to ErrorPagesService and make it configurable through env #1619

merged 5 commits into from
Sep 27, 2023

Conversation

art-alexeyenko
Copy link
Contributor

Description / Motivation

Follow up to rate limits PR.
ErrorPages service from SXA may cause trouble during build when rate limits are enabled. This PR extends retryer functionality to that service and makes retry count be configurable through env (GRAPH_QL_SERVICE_RETRIES).

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team September 25, 2023 21:07
@art-alexeyenko
Copy link
Contributor Author

@matkovskyi could you take a look at this?
We work to cicrcumvent GraphQL Edge's rate limits and ensure nextjs SSG apps can build when rate limits are reached (through a retryer). Main PR for it is here #1618 .
It all works well in non-sxa setup when retries are only enabled on layout and dictionary service - but for SXA we need to apply it on ErrorPagesService too. To make the configuration easier and developer experience better, an env variable is added - but devs can still configure each service individually through other means.
We need your approval on modifying the sxa template and adding this env variable.

@art-alexeyenko art-alexeyenko merged commit 3e9cc54 into dev Sep 27, 2023
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-505-error-pages-and-env branch September 27, 2023 19:29
sc-addypathania
sc-addypathania approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@sc-addypathania sc-addypathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

art-alexeyenko added a commit that referenced this pull request Sep 28, 2023
@art-alexeyenko
[templates/nextjs][templates/nextjs-sxa] Extend retrier to ErrorPages…
1c81fd6 
…Service and make it configurable through env (#1619)
@illiakovalenko illiakovalenko mentioned this pull request Oct 12, 2023
Merged
7 tasks
illiakovalenko added a commit that referenced this pull request Oct 12, 2023
@illiakovalenko
Merge #1612 #1618 #1619 for release 20.2 (#1631)
db870a9 
* [sitecore-jss-nextjs] Reduce the amount of Edge API calls during fetch `getStaticPaths`  (#1612)

* [sitecore-jss][templates/nextjs][templates/nextjs-sxa] Handle rate limit errors in Layout and Dictionary Services through GraphQL Client

* Updated CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc-addypathania sc-addypathania sc-addypathania approved these changes

@matkovskyi matkovskyi matkovskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@art-alexeyenko @sc-addypathania @matkovskyi