[nextjs-personalize] Upgrade Engage to latest
#1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-addypathania
added
do-not-review
sc-addypathania
changed the title
Engage to 1.4.0Engage to latest
ambrauer
requested changes
Sep 12, 2023
packages/create-sitecore-jss/src/templates/nextjs-personalize/src/components/CdpPageView.tsx
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
|
@sc-addypathania @ambrauer - we might need to hold the merging of this PR since we might not include this in the 21.4.0 release due to some changes in priority. |
ambrauer
approved these changes
Sep 15, 2023
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/middleware/personalize-middleware.ts
Outdated
Show resolved
Hide resolved
ambrauer
reviewed
Sep 18, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded
engagepersonalize dependency in jss to1.4.0Removed
cdpServicefrom @sitecore-jss/sitecore-jssReplaced cdpService methods -->
executeExperienceandgenerateBrowserIdwith out of the box engage functions -->personalizeandhandleCookiefunction.feature/jss-301-upgrade-engage
Added @sitecore/engage as peer dependency to @sitecore-jss-nextjs.
This PR follows the Contribution Guide
Changelog updated
Description / Motivation
Testing Details
Types of changes