Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BYOC] Productize move of FEAASWrapper and BYOCWrapper to base packages #1605

Merged
merged 19 commits into from
Sep 7, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Sep 5, 2023

Description / Motivation

  • Updated @sitecore-feaas/clientside to the latest version
  • Introduced next-config/plugins/feaas and updated next-config/plugins/monorepo to solve issues arising due to FEAAS SDK's dual CommonJS/ES module support on the server (via conditional exports). See https://nodejs.org/api/packages.html#dual-package-hazard.
  • Removed FEaaSWrapper, BYOCWrapper from nextjs-sxa add-on
  • Introduced FEaaSWrapper as a part of nextjs + react sdk
  • Introduced BYOCWrapper as a part of react sdk
  • Updated React Placeholder to keep fallback BYOC, FEaaS (component, wrapper) components in case they are not a part of componentFactory
  • Added unit tests
  • Pulled changes from feature/JSS-359-spike-feaas-byoc-base-package branch

Testing Details

  • Unit Test Added
  • Manual Test/Other - Added FEaaS/BYOC components on the page and verified that they are working as expected

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team September 5, 2023 18:41
Copy link
Contributor

@art-alexeyenko art-alexeyenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a large chunk of work, well done.
I left a couple comments below

@art-alexeyenko art-alexeyenko merged commit d85b881 into dev Sep 7, 2023
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/JSS-600 branch September 7, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants