Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[template/nextjs] Next config header plugin for CORS #1597

Merged
merged 3 commits into from
Aug 21, 2023
Merged

[template/nextjs] Next config header plugin for CORS #1597

merged 3 commits into from
Aug 21, 2023

Conversation

sc-addypathania
Copy link
Contributor

@sc-addypathania sc-addypathania commented Aug 21, 2023 •
edited
Loading

This new plugin helps fix CORS issue on CM host, also when trying to use different fonts from remote sources on XMCloud.

Description / Motivation

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sc-addypathania sc-addypathania requested a review from a team August 21, 2023 18:51
ambrauer
ambrauer approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ambrauer ambrauer merged commit febabfc into dev Aug 21, 2023
1 check passed
@ambrauer ambrauer deleted the bugfix/jss-384-cors branch August 21, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sc-addypathania @ambrauer